Allow passing String to Encoding::encode#77
Open
jyn514 wants to merge 2 commits intohsivonen:mainfrom
Open
Conversation
In the common case when converting from UTF8 to UTF8, or the string is all ASCII, this avoids an extra heap allocation for the caller if they only have a `String` available. Previously, they would have to call `encoding.encode(&string).into_owned()` to avoid lifetime errors.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the common case when converting from UTF8 to UTF8, or the string is all ASCII, this avoids an
extra heap allocation for the caller if they only have a
Stringavailable.Previously, they would have to call
encoding.encode(&string).into_owned()to avoid lifetime errors.This change is backwards compatible.